Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR Comment to be more helpful #73

Merged
merged 3 commits into from
May 16, 2024
Merged

Update PR Comment to be more helpful #73

merged 3 commits into from
May 16, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented May 15, 2024

In this PR:

  • Moved the code that picks a default value for inputs.root-sbd into it's own job, as it's being used in more places than just the check-configs job
  • Updated the PR Comment to have more info on accessing the binaries. It will now look something like:

This access-om2 model will be deployed as:

  • 2024.04.0 as a Release (when merged).
  • pr60-8 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using module use /g/data/vk83/prerelease/modules/access-models/ && module load access-om2/pr60-8, where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.21/spack in the access-om2-pr60-8 environment.

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.


Closes #70

@CodeGat CodeGat self-assigned this May 15, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 6a47df3 into main May 16, 2024
@CodeGat CodeGat deleted the better-pr-comment branch May 16, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locating pre-release binaries is difficult
2 participants